Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added the ability to flag a select as multiple-select #92

Merged
merged 2 commits into from May 2, 2012
Merged

added the ability to flag a select as multiple-select #92

merged 2 commits into from May 2, 2012

Conversation

sontek
Copy link
Member

@sontek sontek commented May 2, 2012

No description provided.

@sontek
Copy link
Member Author

sontek commented May 2, 2012

deformdemo test for this is here: Pylons/deformdemo#7

<select name="${field.name}"
id="${field.oid}"
tal:attributes="size field.widget.size"
tal:attributes="class field.widget.css_class">
tal:attributes="class field.widget.css_class"
tal:attributes="multiple field.widget.multiple">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not double tal:attributes (use tal:a="id val;id val")

@kiorky
Copy link
Member

kiorky commented May 2, 2012

Please add a test for multiple selects, i have it on a personal project and at first i broke the widget.

@kiorky
Copy link
Member

kiorky commented May 2, 2012

Ho i didnt read all ! lookin the test

@kiorky
Copy link
Member

kiorky commented May 2, 2012

Ok, fix double tal:a, & i merge !

@sontek
Copy link
Member Author

sontek commented May 2, 2012

I'm not a chameleon guy, have never used it before and don't know what you want, sorry!

@kiorky
Copy link
Member

kiorky commented May 2, 2012

A big Thanks!

kiorky added a commit that referenced this pull request May 2, 2012
added the ability to flag a select as multiple-select
@kiorky kiorky merged commit df64b3f into Pylons:master May 2, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants